summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorxinhui pan <xinhui.pan@amd.com>2021-09-11 09:41:29 +0800
committerAlex Deucher <alexander.deucher@amd.com>2021-09-14 15:59:58 -0400
commit0fcfb30019d3e0b891a201e41262b926648c38b0 (patch)
treebccd8e5b5b0e287f17d3685271ddc2a0939afc3c /drivers
parent405a81ae3fe81a175ef51e6f4ed240744370163e (diff)
downloadlinux-stable-0fcfb30019d3e0b891a201e41262b926648c38b0.tar.gz
linux-stable-0fcfb30019d3e0b891a201e41262b926648c38b0.tar.bz2
linux-stable-0fcfb30019d3e0b891a201e41262b926648c38b0.zip
drm/amdgpu: Fix a race of IB test
Direct IB submission should be exclusive. So use write lock. Signed-off-by: xinhui pan <xinhui.pan@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index 97d88f3e1c4c..074ffcf0dac2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -1358,7 +1358,7 @@ static int amdgpu_debugfs_test_ib_show(struct seq_file *m, void *unused)
}
/* Avoid accidently unparking the sched thread during GPU reset */
- r = down_read_killable(&adev->reset_sem);
+ r = down_write_killable(&adev->reset_sem);
if (r)
return r;
@@ -1387,7 +1387,7 @@ static int amdgpu_debugfs_test_ib_show(struct seq_file *m, void *unused)
kthread_unpark(ring->sched.thread);
}
- up_read(&adev->reset_sem);
+ up_write(&adev->reset_sem);
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put_autosuspend(dev->dev);