diff options
| author | Doug Berger <opendmb@gmail.com> | 2024-04-25 15:27:20 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-04-29 06:24:22 +0100 |
| commit | 2dbe5f19368caae63b1f59f5bc2af78c7d522b3a (patch) | |
| tree | cbfb2ca2486c1775824d2ca716fc7dce9f1a900b /drivers | |
| parent | d85cf67a339685beae1d0aee27b7f61da95455be (diff) | |
| download | linux-stable-2dbe5f19368caae63b1f59f5bc2af78c7d522b3a.tar.gz linux-stable-2dbe5f19368caae63b1f59f5bc2af78c7d522b3a.tar.bz2 linux-stable-2dbe5f19368caae63b1f59f5bc2af78c7d522b3a.zip | |
net: bcmgenet: synchronize use of bcmgenet_set_rx_mode()
The ndo_set_rx_mode function is synchronized with the
netif_addr_lock spinlock and BHs disabled. Since this
function is also invoked directly from the driver the
same synchronization should be applied.
Fixes: 72f96347628e ("net: bcmgenet: set Rx mode before starting netif")
Cc: stable@vger.kernel.org
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index b1f84b37032a..5452b7dc6e6a 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -2,7 +2,7 @@ /* * Broadcom GENET (Gigabit Ethernet) controller driver * - * Copyright (c) 2014-2020 Broadcom + * Copyright (c) 2014-2024 Broadcom */ #define pr_fmt(fmt) "bcmgenet: " fmt @@ -3334,7 +3334,9 @@ static void bcmgenet_netif_start(struct net_device *dev) struct bcmgenet_priv *priv = netdev_priv(dev); /* Start the network engine */ + netif_addr_lock_bh(dev); bcmgenet_set_rx_mode(dev); + netif_addr_unlock_bh(dev); bcmgenet_enable_rx_napi(priv); umac_enable_set(priv, CMD_TX_EN | CMD_RX_EN, true); |