diff options
| author | Mihaela Muraru <mihaela.muraru21@gmail.com> | 2016-10-11 19:54:42 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-10-16 10:26:30 +0200 |
| commit | 32623b0d28e53f926d962c863ce9a62ddc70f376 (patch) | |
| tree | 6a0eac4014f37b4b295980725ba612673e02130d /drivers | |
| parent | f9d033c8ecef66365d78db31c18eda1be86136bc (diff) | |
| download | linux-stable-32623b0d28e53f926d962c863ce9a62ddc70f376.tar.gz linux-stable-32623b0d28e53f926d962c863ce9a62ddc70f376.tar.bz2 linux-stable-32623b0d28e53f926d962c863ce9a62ddc70f376.zip | |
Staging: wilc1000: Replace memcpy by ether_addr_copy
This patch fixes the following checkpatch.pl warning: Prefer
ether_addr_copy() over memcpy() if the Ethernet addresses are
__aligned(2)
According to ether_addr_copy() description and functionality, all
Ethernet addresses should align to the u16 datatype.
Here is the output of pahole for the relevant datastructures:
struct del_sta {
u8 mac_addr[6]; /* 0 6 */
/* size: 6, cachelines: 1, members: 1 */
/* last cacheline: 6 bytes */
};
struct sta_inactive_t {
u8 mac[6]; /* 0 6 */
/* size: 6, cachelines: 1, members: 1 */
/* last cacheline: 6 bytes */
};
Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/wilc1000/host_interface.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index ff3d267c2eb0..0c5dea78807d 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -1930,7 +1930,7 @@ static s32 Handle_Get_InActiveTime(struct wilc_vif *vif, wid.val = kmalloc(wid.size, GFP_KERNEL); stamac = wid.val; - memcpy(stamac, strHostIfStaInactiveT->mac, ETH_ALEN); + ether_addr_copy(stamac, strHostIfStaInactiveT->mac); result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1, wilc_get_vif_idx(vif)); @@ -2166,7 +2166,7 @@ static void Handle_DelStation(struct wilc_vif *vif, pu8CurrByte = wid.val; - memcpy(pu8CurrByte, pstrDelStaParam->mac_addr, ETH_ALEN); + ether_addr_copy(pu8CurrByte, pstrDelStaParam->mac_addr); result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1, wilc_get_vif_idx(vif)); |