diff options
| author | Johan Hovold <johan+linaro@kernel.org> | 2024-09-11 13:52:52 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-10-17 18:33:46 +0530 |
| commit | 34c21f94fa1e147a19b54b6adf0c93a623b70dd8 (patch) | |
| tree | 64e6d949c52943087f6ca0ef90109cc1273025ce /drivers | |
| parent | 29240130ab77c80bea1464317ae2a5fd29c16a0c (diff) | |
| download | linux-stable-34c21f94fa1e147a19b54b6adf0c93a623b70dd8.tar.gz linux-stable-34c21f94fa1e147a19b54b6adf0c93a623b70dd8.tar.bz2 linux-stable-34c21f94fa1e147a19b54b6adf0c93a623b70dd8.zip | |
phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend
Commit 413db06c05e7 ("phy: qcom-qmp-usb: clean up probe initialisation")
removed most users of the platform device driver data from the
qcom-qmp-usb driver, but mistakenly also removed the initialisation
despite the data still being used in the runtime PM callbacks. This bug
was later reproduced when the driver was copied to create the qmp-usbc
driver.
Restore the driver data initialisation at probe to avoid a NULL-pointer
dereference on runtime suspend.
Apparently no one uses runtime PM, which currently needs to be enabled
manually through sysfs, with these drivers.
Fixes: 19281571a4d5 ("phy: qcom: qmp-usb: split USB-C PHY driver")
Cc: stable@vger.kernel.org # 6.9
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20240911115253.10920-4-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c index d4fa1063ea61..cf12a6f12134 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c @@ -1050,6 +1050,7 @@ static int qmp_usbc_probe(struct platform_device *pdev) return -ENOMEM; qmp->dev = dev; + dev_set_drvdata(dev, qmp); qmp->orientation = TYPEC_ORIENTATION_NORMAL; |