diff options
| author | Wentao_Liang <Wentao_Liang_g@163.com> | 2021-08-19 22:30:05 +0800 |
|---|---|---|
| committer | Saeed Mahameed <saeedm@nvidia.com> | 2021-08-26 15:15:42 -0700 |
| commit | 6cc64770fb386b10a64a1fe09328396de7bb5262 (patch) | |
| tree | 19dcf3daf00c61d52735d78f57e3013c8a90649d /drivers | |
| parent | f9d196bd632b8b79261ec3366c30ec3923ea9a02 (diff) | |
| download | linux-stable-6cc64770fb386b10a64a1fe09328396de7bb5262.tar.gz linux-stable-6cc64770fb386b10a64a1fe09328396de7bb5262.tar.bz2 linux-stable-6cc64770fb386b10a64a1fe09328396de7bb5262.zip | |
net/mlx5: DR, fix a potential use-after-free bug
In line 849 (#1), "mlx5dr_htbl_put(cur_htbl);" drops the reference to
cur_htbl and may cause cur_htbl to be freed.
However, cur_htbl is subsequently used in the next line, which may result
in an use-after-free bug.
Fix this by calling mlx5dr_err() before the cur_htbl is put.
Signed-off-by: Wentao_Liang <Wentao_Liang_g@163.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c index 43356fad53de..ffdfb5a94b14 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_rule.c @@ -846,9 +846,9 @@ again: new_htbl = dr_rule_rehash(rule, nic_rule, cur_htbl, ste_location, send_ste_list); if (!new_htbl) { - mlx5dr_htbl_put(cur_htbl); mlx5dr_err(dmn, "Failed creating rehash table, htbl-log_size: %d\n", cur_htbl->chunk_size); + mlx5dr_htbl_put(cur_htbl); } else { cur_htbl = new_htbl; } |