summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorkatrinzhou <katrinzhou@tencent.com>2022-06-21 13:49:26 +0100
committerJani Nikula <jani.nikula@intel.com>2022-06-27 18:12:03 +0300
commit9efdd519d001ee3e761f6ff80d5eb123387421c1 (patch)
tree827a88ec1c027280b6b10804f4d723fac3c3ad38 /drivers
parent03c765b0e3b4cb5063276b086c76f7a612856a9a (diff)
downloadlinux-stable-9efdd519d001ee3e761f6ff80d5eb123387421c1.tar.gz
linux-stable-9efdd519d001ee3e761f6ff80d5eb123387421c1.tar.bz2
linux-stable-9efdd519d001ee3e761f6ff80d5eb123387421c1.zip
drm/i915/gem: add missing else
Add missing else in set_proto_ctx_param() to fix coverity issue. Addresses-Coverity: ("Unused value") Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Signed-off-by: katrinzhou <katrinzhou@tencent.com> [tursulin: fixup alignment] Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220621124926.615884-1-tvrtko.ursulin@linux.intel.com (cherry picked from commit 7482a65664c16cc88eb84d2b545a1fed887378a1) Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpu/drm/i915/gem/i915_gem_context.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index ab4c5ab28e4d..321af109d484 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -933,8 +933,9 @@ static int set_proto_ctx_param(struct drm_i915_file_private *fpriv,
case I915_CONTEXT_PARAM_PERSISTENCE:
if (args->size)
ret = -EINVAL;
- ret = proto_context_set_persistence(fpriv->dev_priv, pc,
- args->value);
+ else
+ ret = proto_context_set_persistence(fpriv->dev_priv, pc,
+ args->value);
break;
case I915_CONTEXT_PARAM_PROTECTED_CONTENT: