summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>2023-09-17 10:58:37 +0200
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2023-09-25 08:41:07 +0200
commit9f93f18305f5777820491e6ab9b34422c160371b (patch)
tree7e5f76a0187abe5c4808420e8fa457f23739817f /drivers
parentdb8588f95cc5e4c9d134f7f4f939b1eade419560 (diff)
downloadlinux-stable-9f93f18305f5777820491e6ab9b34422c160371b.tar.gz
linux-stable-9f93f18305f5777820491e6ab9b34422c160371b.tar.bz2
linux-stable-9f93f18305f5777820491e6ab9b34422c160371b.zip
gpio: sim: initialize a managed pointer when declaring it
Variables managed with __free() should typically be initialized where they are declared so that the __free() callback is paired with its counterpart resource allocator. Fix the second instance of using __free() in gpio-sim to follow this pattern. Fixes: 3faf89f27aab ("gpio: sim: simplify code with cleanup helpers") Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpio/gpio-sim.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 59cba5b5f54a..460389bb8e3f 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -1485,10 +1485,10 @@ static const struct config_item_type gpio_sim_device_config_group_type = {
static struct config_group *
gpio_sim_config_make_device_group(struct config_group *group, const char *name)
{
- struct gpio_sim_device *dev __free(kfree) = NULL;
int id;
- dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+ struct gpio_sim_device *dev __free(kfree) = kzalloc(sizeof(*dev),
+ GFP_KERNEL);
if (!dev)
return ERR_PTR(-ENOMEM);