summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAndreas Platschek <andreas.platschek@opentech.at>2017-12-07 11:32:20 +0100
committerFelipe Balbi <felipe.balbi@linux.intel.com>2017-12-11 12:35:36 +0200
commitded600ea9fb51a495d2fcd21e90351df876488e8 (patch)
tree7826e796c47843abae79921d939914a5cde783b0 /drivers
parent8722e095f5a44d0e409e45c5ddc2ee9cf589c777 (diff)
downloadlinux-stable-ded600ea9fb51a495d2fcd21e90351df876488e8.tar.gz
linux-stable-ded600ea9fb51a495d2fcd21e90351df876488e8.tar.bz2
linux-stable-ded600ea9fb51a495d2fcd21e90351df876488e8.zip
usb: dwc3: of-simple: fix missing clk_disable_unprepare
If of_clk_get() fails, the clean-up of already initialized clocks should be the same as when clk_prepare_enable() fails. Thus a clk_disable_unprepare() for each clock should be called before the clk_put(). Found by Linux Driver Verification project (linuxtesting.org). Fixes: 16adc674d0d6 ("usb: dwc3: ep0: fix setup_packet_pending initialization") Signed-off-by: Andreas Platschek <andreas.platschek@opentech.at> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/dwc3/dwc3-of-simple.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index c4a4d7bd2766..762370dd7c75 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -51,8 +51,10 @@ static int dwc3_of_simple_clk_init(struct dwc3_of_simple *simple, int count)
clk = of_clk_get(np, i);
if (IS_ERR(clk)) {
- while (--i >= 0)
+ while (--i >= 0) {
+ clk_disable_unprepare(simple->clks[i]);
clk_put(simple->clks[i]);
+ }
return PTR_ERR(clk);
}