summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorAsbjørn Sloth Tønnesen <ast@fiberby.net>2024-04-26 09:12:26 +0000
committerDavid S. Miller <davem@davemloft.net>2024-04-29 10:02:43 +0100
commitf26f719a36e56381a1f4230e5364e7ad4d485888 (patch)
tree53d1f19dbc871a52a4667cb943c8e80c5b746182 /drivers
parent27b44414a34b108c5a37cd5b4894f606061d86e7 (diff)
downloadlinux-stable-f26f719a36e56381a1f4230e5364e7ad4d485888.tar.gz
linux-stable-f26f719a36e56381a1f4230e5364e7ad4d485888.tar.bz2
linux-stable-f26f719a36e56381a1f4230e5364e7ad4d485888.zip
net: qede: use return from qede_parse_actions()
When calling qede_parse_actions() then the return code was only used for a non-zero check, and then -EINVAL was returned. qede_parse_actions() can currently fail with: * -EINVAL * -EOPNOTSUPP This patch changes the code to use the actual return code, not just return -EINVAL. The blaimed commit broke the implicit assumption that only -EINVAL would ever be returned. Only compile tested. Fixes: 319a1d19471e ("flow_offload: check for basic action hw stats type") Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/qlogic/qede/qede_filter.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
index 377d661f70f7..cb6b33a228ea 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
@@ -1894,10 +1894,9 @@ int qede_add_tc_flower_fltr(struct qede_dev *edev, __be16 proto,
}
/* parse tc actions and get the vf_id */
- if (qede_parse_actions(edev, &f->rule->action, f->common.extack)) {
- rc = -EINVAL;
+ rc = qede_parse_actions(edev, &f->rule->action, f->common.extack);
+ if (rc)
goto unlock;
- }
if (qede_flow_find_fltr(edev, &t)) {
rc = -EEXIST;