summaryrefslogtreecommitdiffstats
path: root/fs/btrfs/export.c
diff options
context:
space:
mode:
authorDavid Sterba <dsterba@suse.com>2024-01-19 21:19:18 +0100
committerDavid Sterba <dsterba@suse.com>2024-03-04 16:24:47 +0100
commit26b66d1d366a375745755ca7365f67110bbf6bd5 (patch)
tree92a8b2b8682806ed1cd29a5b22b02cc8725703a7 /fs/btrfs/export.c
parenta4259b6c191119f270561c75eee840363f697c04 (diff)
downloadlinux-stable-26b66d1d366a375745755ca7365f67110bbf6bd5.tar.gz
linux-stable-26b66d1d366a375745755ca7365f67110bbf6bd5.tar.bz2
linux-stable-26b66d1d366a375745755ca7365f67110bbf6bd5.zip
btrfs: export: handle invalid inode or root reference in btrfs_get_parent()
The get_parent handler looks up a parent of a given dentry, this can be either a subvolume or a directory. The search is set up with offset -1 but it's never expected to find such item, as it would break allowed range of inode number or a root id. This means it's a corruption (ext4 also returns this error code). Reviewed-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: Anand Jain <anand.jain@oracle.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/export.c')
-rw-r--r--fs/btrfs/export.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/fs/btrfs/export.c b/fs/btrfs/export.c
index 3f2e8fb9e3e9..d710339ca4f3 100644
--- a/fs/btrfs/export.c
+++ b/fs/btrfs/export.c
@@ -173,8 +173,15 @@ struct dentry *btrfs_get_parent(struct dentry *child)
ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
if (ret < 0)
goto fail;
+ if (ret == 0) {
+ /*
+ * Key with offset of -1 found, there would have to exist an
+ * inode with such number or a root with such id.
+ */
+ ret = -EUCLEAN;
+ goto fail;
+ }
- BUG_ON(ret == 0); /* Key with offset of -1 found */
if (path->slots[0] == 0) {
ret = -ENOENT;
goto fail;