diff options
| author | Zhao Lei <zhaolei@cn.fujitsu.com> | 2015-02-24 20:07:44 +0800 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2015-04-13 07:27:35 -0700 |
| commit | 18d018ad2c899d3d9c503c25125d56046ed7d3ca (patch) | |
| tree | bfb706643c6d3c6e7e986ad5a45741d186207490 /fs/btrfs | |
| parent | c30666d466c70a30491e45dd8d068360f9dd7693 (diff) | |
| download | linux-stable-18d018ad2c899d3d9c503c25125d56046ed7d3ca.tar.gz linux-stable-18d018ad2c899d3d9c503c25125d56046ed7d3ca.tar.bz2 linux-stable-18d018ad2c899d3d9c503c25125d56046ed7d3ca.zip | |
btrfs: add WARN_ON() to check is space_info op current
space_info's value calculation is some complex and easy to cause
bug, add WARN_ON() to help debug.
Changelog v1->v2:
Put WARN_ON()s under the ENOSPC_DEBUG mount option.
Suggested by: David Sterba <dsterba@suse.cz>
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/extent-tree.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 7a14a4aa50a7..be4a79a69ed1 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -9732,9 +9732,19 @@ int btrfs_remove_block_group(struct btrfs_trans_handle *trans, spin_lock(&block_group->space_info->lock); list_del_init(&block_group->ro_list); + + if (btrfs_test_opt(root, ENOSPC_DEBUG)) { + WARN_ON(block_group->space_info->total_bytes + < block_group->key.offset); + WARN_ON(block_group->space_info->bytes_readonly + < block_group->key.offset); + WARN_ON(block_group->space_info->disk_total + < block_group->key.offset * factor); + } block_group->space_info->total_bytes -= block_group->key.offset; block_group->space_info->bytes_readonly -= block_group->key.offset; block_group->space_info->disk_total -= block_group->key.offset * factor; + spin_unlock(&block_group->space_info->lock); memcpy(&key, &block_group->key, sizeof(key)); |