summaryrefslogtreecommitdiffstats
path: root/fs/cifs/link.c
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2023-01-11 12:37:58 +0100
committerSteve French <stfrench@microsoft.com>2023-01-12 09:51:48 -0600
commita152d05ae4a71d802d50cf9177dba34e8bb09f68 (patch)
treee2fa322baa74c92ba1a3c2a72f32071912a5b4c9 /fs/cifs/link.c
parent2fe58d977ee05da5bb89ef5dc4f5bf2dc15db46f (diff)
downloadlinux-stable-a152d05ae4a71d802d50cf9177dba34e8bb09f68.tar.gz
linux-stable-a152d05ae4a71d802d50cf9177dba34e8bb09f68.tar.bz2
linux-stable-a152d05ae4a71d802d50cf9177dba34e8bb09f68.zip
cifs: Fix uninitialized memory read for smb311 posix symlink create
If smb311 posix is enabled, we send the intended mode for file creation in the posix create context. Instead of using what's there on the stack, create the mfsymlink file with 0644. Fixes: ce558b0e17f8a ("smb3: Add posix create context for smb3.11 posix mounts") Cc: stable@vger.kernel.org Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Tom Talpey <tom@talpey.com> Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/link.c')
-rw-r--r--fs/cifs/link.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index bd374feeccaa..a5a097a69983 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -428,6 +428,7 @@ smb3_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
oparms.disposition = FILE_CREATE;
oparms.fid = &fid;
oparms.reconnect = false;
+ oparms.mode = 0644;
rc = SMB2_open(xid, &oparms, utf16_path, &oplock, NULL, NULL,
NULL, NULL);