diff options
| author | Paulo Alcantara <pc@cjr.nz> | 2022-04-20 21:05:46 -0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-04-20 22:54:39 -0500 |
| commit | cd70a3e8988a999c42d307d2616a5e7b6a33c7c8 (patch) | |
| tree | 780c9c13af372e0e7baf42de0b1589d13c842198 /fs/cifs | |
| parent | 41f10081a92a0ed280008218a8ec18ad8ba0fceb (diff) | |
| download | linux-stable-cd70a3e8988a999c42d307d2616a5e7b6a33c7c8.tar.gz linux-stable-cd70a3e8988a999c42d307d2616a5e7b6a33c7c8.tar.bz2 linux-stable-cd70a3e8988a999c42d307d2616a5e7b6a33c7c8.zip | |
cifs: use correct lock type in cifs_reconnect()
TCP_Server_Info::origin_fullpath and TCP_Server_Info::leaf_fullpath
are protected by refpath_lock mutex and not cifs_tcp_ses_lock
spinlock.
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Cc: stable@vger.kernel.org
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/connect.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 2c24d433061a..42e14f408856 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -534,12 +534,19 @@ int cifs_reconnect(struct TCP_Server_Info *server, bool mark_smb_session) { /* If tcp session is not an dfs connection, then reconnect to last target server */ spin_lock(&cifs_tcp_ses_lock); - if (!server->is_dfs_conn || !server->origin_fullpath || !server->leaf_fullpath) { + if (!server->is_dfs_conn) { spin_unlock(&cifs_tcp_ses_lock); return __cifs_reconnect(server, mark_smb_session); } spin_unlock(&cifs_tcp_ses_lock); + mutex_lock(&server->refpath_lock); + if (!server->origin_fullpath || !server->leaf_fullpath) { + mutex_unlock(&server->refpath_lock); + return __cifs_reconnect(server, mark_smb_session); + } + mutex_unlock(&server->refpath_lock); + return reconnect_dfs_server(server); } #else |