diff options
| author | Eric Biggers <ebiggers@google.com> | 2023-03-20 16:39:43 -0700 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2023-03-27 21:15:50 -0700 |
| commit | 41b2ad80fdcaafd42fce173cb95847d0cd8614c2 (patch) | |
| tree | 633980d206be0ae2ce7215bd46207b0a5a1cf02e /fs/crypto/fname.c | |
| parent | 6f2656eab290f0dd437cd4b2ec956c3519172d3b (diff) | |
| download | linux-stable-41b2ad80fdcaafd42fce173cb95847d0cd8614c2.tar.gz linux-stable-41b2ad80fdcaafd42fce173cb95847d0cd8614c2.tar.bz2 linux-stable-41b2ad80fdcaafd42fce173cb95847d0cd8614c2.zip | |
fscrypt: use WARN_ON_ONCE instead of WARN_ON
As per Linus's suggestion
(https://lore.kernel.org/r/CAHk-=whefxRGyNGzCzG6BVeM=5vnvgb-XhSeFJVxJyAxAF8XRA@mail.gmail.com),
use WARN_ON_ONCE instead of WARN_ON. This barely adds any extra
overhead, and it makes it so that if any of these ever becomes reachable
(they shouldn't, but that's the point), the logs can't be flooded.
Link: https://lore.kernel.org/r/20230320233943.73600-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'fs/crypto/fname.c')
| -rw-r--r-- | fs/crypto/fname.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/crypto/fname.c b/fs/crypto/fname.c index 12bd61d20f69..6eae3f12ad50 100644 --- a/fs/crypto/fname.c +++ b/fs/crypto/fname.c @@ -110,7 +110,7 @@ int fscrypt_fname_encrypt(const struct inode *inode, const struct qstr *iname, * Copy the filename to the output buffer for encrypting in-place and * pad it with the needed number of NUL bytes. */ - if (WARN_ON(olen < iname->len)) + if (WARN_ON_ONCE(olen < iname->len)) return -ENOBUFS; memcpy(out, iname->name, iname->len); memset(out + iname->len, 0, olen - iname->len); @@ -570,7 +570,7 @@ u64 fscrypt_fname_siphash(const struct inode *dir, const struct qstr *name) { const struct fscrypt_info *ci = dir->i_crypt_info; - WARN_ON(!ci->ci_dirhash_key_initialized); + WARN_ON_ONCE(!ci->ci_dirhash_key_initialized); return siphash(name->name, name->len, &ci->ci_dirhash_key); } |