diff options
| author | Gao Xiang <hsiangkao@linux.alibaba.com> | 2024-06-30 02:57:43 +0800 |
|---|---|---|
| committer | Gao Xiang <hsiangkao@linux.alibaba.com> | 2024-06-30 10:54:28 +0800 |
| commit | 9b32b063be1001e322c5f6e01f2a649636947851 (patch) | |
| tree | d3ec220aa18aef77304dba31683ab0b950de5021 /fs/erofs | |
| parent | cc69a681b2573e8865e29758f1a5b284328efb2d (diff) | |
| download | linux-stable-9b32b063be1001e322c5f6e01f2a649636947851.tar.gz linux-stable-9b32b063be1001e322c5f6e01f2a649636947851.tar.bz2 linux-stable-9b32b063be1001e322c5f6e01f2a649636947851.zip | |
erofs: ensure m_llen is reset to 0 if metadata is invalid
Sometimes, the on-disk metadata might be invalid due to user
interrupts, storage failures, or other unknown causes.
In that case, z_erofs_map_blocks_iter() may still return a valid
m_llen while other fields remain invalid (e.g., m_plen can be 0).
Due to the return value of z_erofs_scan_folio() in some path will
be ignored on purpose, the following z_erofs_scan_folio() could
then use the invalid value by accident.
Let's reset m_llen to 0 to prevent this.
Link: https://lore.kernel.org/r/20240629185743.2819229-1-hsiangkao@linux.alibaba.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Diffstat (limited to 'fs/erofs')
| -rw-r--r-- | fs/erofs/zmap.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/erofs/zmap.c b/fs/erofs/zmap.c index 9b248ee5fef2..74d3d7bffcf3 100644 --- a/fs/erofs/zmap.c +++ b/fs/erofs/zmap.c @@ -711,6 +711,8 @@ int z_erofs_map_blocks_iter(struct inode *inode, struct erofs_map_blocks *map, err = z_erofs_do_map_blocks(inode, map, flags); out: + if (err) + map->m_llen = 0; trace_z_erofs_map_blocks_iter_exit(inode, map, flags, err); return err; } |