summaryrefslogtreecommitdiffstats
path: root/fs/ext4/ioctl.c
diff options
context:
space:
mode:
authorZhang Yi <yi.zhang@huawei.com>2023-01-29 11:49:39 +0800
committerTheodore Ts'o <tytso@mit.edu>2023-02-25 15:39:08 -0500
commite3645d72f8865ffe36f9dc811540d40aa3c848d3 (patch)
treee1cc4706df4c069a648e43839fc73cbb310fe7d6 /fs/ext4/ioctl.c
parent0813299c586b175d7edb25f56412c54b812d0379 (diff)
downloadlinux-stable-e3645d72f8865ffe36f9dc811540d40aa3c848d3.tar.gz
linux-stable-e3645d72f8865ffe36f9dc811540d40aa3c848d3.tar.bz2
linux-stable-e3645d72f8865ffe36f9dc811540d40aa3c848d3.zip
ext4: fix incorrect options show of original mount_opt and extend mount_opt2
Current _ext4_show_options() do not distinguish MOPT_2 flag, so it mixed extend sbi->s_mount_opt2 options with sbi->s_mount_opt, it could lead to show incorrect options, e.g. show fc_debug_force if we mount with errors=continue mode and miss it if we set. $ mkfs.ext4 /dev/pmem0 $ mount -o errors=remount-ro /dev/pmem0 /mnt $ cat /proc/fs/ext4/pmem0/options | grep fc_debug_force #empty $ mount -o remount,errors=continue /mnt $ cat /proc/fs/ext4/pmem0/options | grep fc_debug_force fc_debug_force $ mount -o remount,errors=remount-ro,fc_debug_force /mnt $ cat /proc/fs/ext4/pmem0/options | grep fc_debug_force #empty Fixes: 995a3ed67fc8 ("ext4: add fast_commit feature and handling for extended mount options") Signed-off-by: Zhang Yi <yi.zhang@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20230129034939.3702550-1-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ioctl.c')
0 files changed, 0 insertions, 0 deletions