summaryrefslogtreecommitdiffstats
path: root/fs/ext4
diff options
context:
space:
mode:
authorJun Nie <jun.nie@linaro.org>2023-01-03 09:45:17 +0800
committerTheodore Ts'o <tytso@mit.edu>2023-02-18 23:58:18 -0500
commitf31173c19901a96bb2ebf6bcfec8a08df7095c91 (patch)
treeb9b88fba67aeb4ebdb3f792a2c7f82fb0102bb24 /fs/ext4
parent1e9d62d252812575ded7c620d8fc67c32ff06c16 (diff)
downloadlinux-stable-f31173c19901a96bb2ebf6bcfec8a08df7095c91.tar.gz
linux-stable-f31173c19901a96bb2ebf6bcfec8a08df7095c91.tar.bz2
linux-stable-f31173c19901a96bb2ebf6bcfec8a08df7095c91.zip
ext4: refuse to create ea block when umounted
The ea block expansion need to access s_root while it is already set as NULL when umount is triggered. Refuse this request to avoid panic. Reported-by: syzbot+2dacb8f015bf1420155f@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=3613786cb88c93aa1c6a279b1df6a7b201347d08 Link: https://lore.kernel.org/r/20230103014517.495275-3-jun.nie@linaro.org Cc: stable@kernel.org Signed-off-by: Jun Nie <jun.nie@linaro.org> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
-rw-r--r--fs/ext4/xattr.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 38e08b438ccb..d8fef540ca9b 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1471,6 +1471,13 @@ static struct inode *ext4_xattr_inode_create(handle_t *handle,
uid_t owner[2] = { i_uid_read(inode), i_gid_read(inode) };
int err;
+ if (inode->i_sb->s_root == NULL) {
+ ext4_warning(inode->i_sb,
+ "refuse to create EA inode when umounting");
+ WARN_ON(1);
+ return ERR_PTR(-EINVAL);
+ }
+
/*
* Let the next inode be the goal, so we try and allocate the EA inode
* in the same group, or nearby one.