diff options
| author | Eric Biggers <ebiggers@google.com> | 2020-11-17 23:56:07 -0800 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2020-11-24 15:10:27 -0800 |
| commit | bfc2b7e8518999003a61f91c1deb5e88ed77b07d (patch) | |
| tree | fdf6b3acdbd5d2a07f1fca0e6bd7d74a071c618f /fs/f2fs | |
| parent | 75d18cd1868c2aee43553723872c35d7908f240f (diff) | |
| download | linux-stable-bfc2b7e8518999003a61f91c1deb5e88ed77b07d.tar.gz linux-stable-bfc2b7e8518999003a61f91c1deb5e88ed77b07d.tar.bz2 linux-stable-bfc2b7e8518999003a61f91c1deb5e88ed77b07d.zip | |
f2fs: prevent creating duplicate encrypted filenames
As described in "fscrypt: add fscrypt_is_nokey_name()", it's possible to
create a duplicate filename in an encrypted directory by creating a file
concurrently with adding the directory's encryption key.
Fix this bug on f2fs by rejecting no-key dentries in f2fs_add_link().
Note that the weird check for the current task in f2fs_do_add_link()
seems to make this bug difficult to reproduce on f2fs.
Fixes: 9ea97163c6da ("f2fs crypto: add filename encryption for f2fs_add_link")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201118075609.120337-4-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'fs/f2fs')
| -rw-r--r-- | fs/f2fs/f2fs.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index cb700d797296..9a321c52face 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3251,6 +3251,8 @@ bool f2fs_empty_dir(struct inode *dir); static inline int f2fs_add_link(struct dentry *dentry, struct inode *inode) { + if (fscrypt_is_nokey_name(dentry)) + return -ENOKEY; return f2fs_do_add_link(d_inode(dentry->d_parent), &dentry->d_name, inode, inode->i_ino, inode->i_mode); } |