diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2023-11-26 02:08:34 +0000 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2023-12-12 14:24:09 +0100 |
| commit | 7cb537b6f6d7d6529be04139178f929d9a63b918 (patch) | |
| tree | 21261fb352f5a3c788e01b5d418869225b17ea54 /fs/internal.h | |
| parent | b85ea95d086471afb4ad062012a4d73cd328fa86 (diff) | |
| download | linux-stable-7cb537b6f6d7d6529be04139178f929d9a63b918.tar.gz linux-stable-7cb537b6f6d7d6529be04139178f929d9a63b918.tar.bz2 linux-stable-7cb537b6f6d7d6529be04139178f929d9a63b918.zip | |
file: massage cleanup of files that failed to open
A file that has never gotten FMODE_OPENED will never have RCU-accessed
references, its final fput() is equivalent to file_free() and if it
doesn't have FMODE_BACKING either, it can be done from any context and
won't need task_work treatment.
Now that we have SLAB_TYPESAFE_BY_RCU we can simplify this and have
other callers benefit. All of that can be achieved easier is to make
fput() recoginze that case and call file_free() directly.
No need to introduce a special primitive for that. It also allowed
things like failing dentry_open() could benefit from that as well.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
[Christian Brauner <brauner@kernel.org>: massage commit message]
Link: https://lore.kernel.org/r/20231126020834.GC38156@ZenIV
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/internal.h')
| -rw-r--r-- | fs/internal.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/internal.h b/fs/internal.h index 58e43341aebf..273e6fd40d1b 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -94,7 +94,6 @@ extern void chroot_fs_refs(const struct path *, const struct path *); struct file *alloc_empty_file(int flags, const struct cred *cred); struct file *alloc_empty_file_noaccount(int flags, const struct cred *cred); struct file *alloc_empty_backing_file(int flags, const struct cred *cred); -void release_empty_file(struct file *f); static inline void file_put_write_access(struct file *file) { |