diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2020-12-11 17:11:12 +0100 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2020-12-11 17:16:55 +0100 |
commit | 23d4e55f7eeb9dadfd03d16ffb24384b49c46c0d (patch) | |
tree | 0659e10c1993c58e55a9afb3e4b8a89635859ce0 /fs/ioctl.c | |
parent | 26e08a6da54c575c69a113ab0c41c2890c0d613d (diff) | |
download | linux-stable-23d4e55f7eeb9dadfd03d16ffb24384b49c46c0d.tar.gz linux-stable-23d4e55f7eeb9dadfd03d16ffb24384b49c46c0d.tar.bz2 linux-stable-23d4e55f7eeb9dadfd03d16ffb24384b49c46c0d.zip |
drm/vkms: Unset preferred_depth
There's a confusion between the preferred_depth uapi and the generic
fbdev helpers. Former wants depth, latter wants bpp, and for XRGB8888
they don't match. Which hit me with vkms, which wants that.
All other drivers setting this and using the generic fbdev helpers use
16, where both numbers match, for RGB565.
Since fixing this is a bit involved (I think for atomic drivers we
should just compute this all internally from the format list of the
first primary plane) paper over the issue in vkms by using defaults
everywhere. Then userspace will pick XRGB8888, and fbdev helpers will
do the same, and we have what we want.
Reported-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Simon Ser <contact@emersion.fr>
Cc: Simon Ser <contact@emersion.fr>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Melissa Wen <melissa.srw@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201211161113.3350061-1-daniel.vetter@ffwll.ch
Diffstat (limited to 'fs/ioctl.c')
0 files changed, 0 insertions, 0 deletions