diff options
| author | Shyam Prasad N <nspmangalore@gmail.com> | 2023-07-14 08:56:34 +0000 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-07-14 11:24:14 -0500 |
| commit | c071b34f62ddbf8435491ebb0e21eba9dc29f901 (patch) | |
| tree | 81e24b9dc33dd34779fbf94713bb75b9dfa1fe41 /fs/smb/client/smb2ops.c | |
| parent | bf99f6be2d20146942bce6f9e90a0ceef12cbc1e (diff) | |
| download | linux-stable-c071b34f62ddbf8435491ebb0e21eba9dc29f901.tar.gz linux-stable-c071b34f62ddbf8435491ebb0e21eba9dc29f901.tar.bz2 linux-stable-c071b34f62ddbf8435491ebb0e21eba9dc29f901.zip | |
cifs: is_network_name_deleted should return a bool
Currently, is_network_name_deleted and it's implementations
do not return anything if the network name did get deleted.
So the function doesn't fully achieve what it advertizes.
Changed the function to return a bool instead. It will now
return true if the error returned is STATUS_NETWORK_NAME_DELETED
and the share (tree id) was found to be connected. It returns
false otherwise.
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Acked-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/smb/client/smb2ops.c')
| -rw-r--r-- | fs/smb/client/smb2ops.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c index 87abce010974..0f62bc373ad0 100644 --- a/fs/smb/client/smb2ops.c +++ b/fs/smb/client/smb2ops.c @@ -2395,7 +2395,7 @@ smb2_is_status_io_timeout(char *buf) return false; } -static void +static bool smb2_is_network_name_deleted(char *buf, struct TCP_Server_Info *server) { struct smb2_hdr *shdr = (struct smb2_hdr *)buf; @@ -2404,7 +2404,7 @@ smb2_is_network_name_deleted(char *buf, struct TCP_Server_Info *server) struct cifs_tcon *tcon; if (shdr->Status != STATUS_NETWORK_NAME_DELETED) - return; + return false; /* If server is a channel, select the primary channel */ pserver = CIFS_SERVER_IS_CHAN(server) ? server->primary_server : server; @@ -2419,11 +2419,13 @@ smb2_is_network_name_deleted(char *buf, struct TCP_Server_Info *server) spin_unlock(&cifs_tcp_ses_lock); pr_warn_once("Server share %s deleted.\n", tcon->tree_name); - return; + return true; } } } spin_unlock(&cifs_tcp_ses_lock); + + return false; } static int |