diff options
| author | Jeff Layton <jlayton@redhat.com> | 2012-02-07 06:31:05 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-02-20 12:46:18 -0800 |
| commit | 23cfecf97911af4ef38afd61879f030af0410755 (patch) | |
| tree | eb14ec7d6b53781fdd4ac98347a0397961a5cd2a /fs | |
| parent | 77d04b76d64e24329bb63d3d8d52c942db61bcb6 (diff) | |
| download | linux-stable-23cfecf97911af4ef38afd61879f030af0410755.tar.gz linux-stable-23cfecf97911af4ef38afd61879f030af0410755.tar.bz2 linux-stable-23cfecf97911af4ef38afd61879f030af0410755.zip | |
cifs: don't return error from standard_receive3 after marking response malformed
commit ff4fa4a25a33f92b5653bb43add0c63bea98d464 upstream.
standard_receive3 will check the validity of the response from the
server (via checkSMB). It'll pass the result of that check to handle_mid
which will dequeue it and mark it with a status of
MID_RESPONSE_MALFORMED if checkSMB returned an error. At that point,
standard_receive3 will also return an error, which will make the
demultiplex thread skip doing the callback for the mid.
This is wrong -- if we were able to identify the request and the
response is marked malformed, then we want the demultiplex thread to do
the callback. Fix this by making standard_receive3 return 0 in this
situation.
Reported-and-Tested-by: Mark Moseley <moseleymark@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/connect.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 63e4be46eec4..720edf52dbf8 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -756,10 +756,11 @@ standard_receive3(struct TCP_Server_Info *server, struct mid_q_entry *mid) cifs_dump_mem("Bad SMB: ", buf, min_t(unsigned int, server->total_read, 48)); - if (mid) - handle_mid(mid, server, smb_buffer, length); + if (!mid) + return length; - return length; + handle_mid(mid, server, smb_buffer, length); + return 0; } static int |