diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2022-05-12 17:08:03 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2022-05-14 18:49:01 -0400 |
commit | 6319194ec57b0452dcda4589d24c4e7db299c5bf (patch) | |
tree | d65162000bc0031c8e5946aa7135c9dad7496d6c /include/linux/amba | |
parent | 81132a39c152ca09832b9e4cb748129cee5f55ec (diff) | |
download | linux-stable-6319194ec57b0452dcda4589d24c4e7db299c5bf.tar.gz linux-stable-6319194ec57b0452dcda4589d24c4e7db299c5bf.tar.bz2 linux-stable-6319194ec57b0452dcda4589d24c4e7db299c5bf.zip |
Unify the primitives for file descriptor closing
Currently we have 3 primitives for removing an opened file from descriptor
table - pick_file(), __close_fd_get_file() and close_fd_get_file(). Their
calling conventions are rather odd and there's a code duplication for no
good reason. They can be unified -
1) have __range_close() cap max_fd in the very beginning; that way
we don't need separate way for pick_file() to report being past the end
of descriptor table.
2) make {__,}close_fd_get_file() return file (or NULL) directly, rather
than returning it via struct file ** argument. Don't bother with
(bogus) return value - nobody wants that -ENOENT.
3) make pick_file() return NULL on unopened descriptor - the only caller
that used to care about the distinction between descriptor past the end
of descriptor table and finding NULL in descriptor table doesn't give
a damn after (1).
4) lift ->files_lock out of pick_file()
That actually simplifies the callers, as well as the primitives themselves.
Code duplication is also gone...
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'include/linux/amba')
0 files changed, 0 insertions, 0 deletions