summaryrefslogtreecommitdiffstats
path: root/include/linux/fscache.h
diff options
context:
space:
mode:
authorDominique Martinet <asmadeus@codewreck.org>2021-11-03 17:34:05 +0900
committerDominique Martinet <asmadeus@codewreck.org>2021-11-03 17:44:29 +0900
commit0dc54bd4d6e03be1f0b678c4297170b79f1a44ab (patch)
treebdd88df1f40a932ee69560d6e364036910fcef28 /include/linux/fscache.h
parent4cd82a5bb0f68236f67b1678bc9e6348a42241ed (diff)
downloadlinux-stable-0dc54bd4d6e03be1f0b678c4297170b79f1a44ab.tar.gz
linux-stable-0dc54bd4d6e03be1f0b678c4297170b79f1a44ab.tar.bz2
linux-stable-0dc54bd4d6e03be1f0b678c4297170b79f1a44ab.zip
fscache_cookie_enabled: check cookie is valid before accessing it
fscache_cookie_enabled() could be called on NULL cookies and cause a null pointer dereference when accessing cookie flags: just make sure the cookie is valid first Suggested-by: David Howells <dhowells@redhat.com> Acked-by: David Howells <dhowells@redhat.com> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Diffstat (limited to 'include/linux/fscache.h')
-rw-r--r--include/linux/fscache.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/fscache.h b/include/linux/fscache.h
index a4dab5998613..3b2282c157f7 100644
--- a/include/linux/fscache.h
+++ b/include/linux/fscache.h
@@ -167,7 +167,7 @@ struct fscache_cookie {
static inline bool fscache_cookie_enabled(struct fscache_cookie *cookie)
{
- return test_bit(FSCACHE_COOKIE_ENABLED, &cookie->flags);
+ return fscache_cookie_valid(cookie) && test_bit(FSCACHE_COOKIE_ENABLED, &cookie->flags);
}
/*