summaryrefslogtreecommitdiffstats
path: root/include/linux/mlx5
diff options
context:
space:
mode:
authorLarysa Zaremba <larysa.zaremba@intel.com>2023-12-05 22:08:42 +0100
committerAlexei Starovoitov <ast@kernel.org>2023-12-13 16:16:41 -0800
commit537fec0733c4a72e2a2b69fee365459c5b75d92e (patch)
tree037548b81a240152a2d37ad07a9a2a3ed3e930f8 /include/linux/mlx5
parentfca783799f64ac0a4f20228ff6a6d7598db11e64 (diff)
downloadlinux-stable-537fec0733c4a72e2a2b69fee365459c5b75d92e.tar.gz
linux-stable-537fec0733c4a72e2a2b69fee365459c5b75d92e.tar.bz2
linux-stable-537fec0733c4a72e2a2b69fee365459c5b75d92e.zip
net: make vlan_get_tag() return -ENODATA instead of -EINVAL
__vlan_hwaccel_get_tag() is used in veth XDP hints implementation, its return value (-EINVAL if skb is not VLAN tagged) is passed to bpf code, but XDP hints specification requires drivers to return -ENODATA, if a hint cannot be provided for a particular packet. Solve this inconsistency by changing error return value of __vlan_hwaccel_get_tag() from -EINVAL to -ENODATA, do the same thing to __vlan_get_tag(), because this function is supposed to follow the same convention. This, in turn, makes -ENODATA the only non-zero value vlan_get_tag() can return. We can do this with no side effects, because none of the users of the 3 above-mentioned functions rely on the exact value. Suggested-by: Jesper Dangaard Brouer <jbrouer@redhat.com> Acked-by: Stanislav Fomichev <sdf@google.com> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com> Link: https://lore.kernel.org/r/20231205210847.28460-14-larysa.zaremba@intel.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'include/linux/mlx5')
0 files changed, 0 insertions, 0 deletions