summaryrefslogtreecommitdiffstats
path: root/include/media
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-04-24 05:46:27 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-05-08 14:02:25 -0400
commitb72845ee5577b227131b1fef23f9d9a296621d7b (patch)
treec4a00b157d0dcb943e8692b1c754fc2703c9eb96 /include/media
parent823a633eeb7775171cbb9f423401316504745dc7 (diff)
downloadlinux-stable-b72845ee5577b227131b1fef23f9d9a296621d7b.tar.gz
linux-stable-b72845ee5577b227131b1fef23f9d9a296621d7b.tar.bz2
linux-stable-b72845ee5577b227131b1fef23f9d9a296621d7b.zip
media: davinci/vpbe: array underflow in vpbe_enum_outputs()
In vpbe_enum_outputs() we check if (temp_index >= cfg->num_outputs) but the problem is that "temp_index" can be negative. This patch changes the types to unsigned to address this array underflow bug. Fixes: 66715cdc3224 ("[media] davinci vpbe: VPBE display driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'include/media')
-rw-r--r--include/media/davinci/vpbe.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/media/davinci/vpbe.h b/include/media/davinci/vpbe.h
index 5c31a7682492..f76d2f25a824 100644
--- a/include/media/davinci/vpbe.h
+++ b/include/media/davinci/vpbe.h
@@ -92,7 +92,7 @@ struct vpbe_config {
struct encoder_config_info *ext_encoders;
/* amplifier information goes here */
struct amp_config_info *amp;
- int num_outputs;
+ unsigned int num_outputs;
/* Order is venc outputs followed by LCD and then external encoders */
struct vpbe_output *outputs;
};