summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorXin Long <lucien.xin@gmail.com>2018-11-15 15:14:30 +0800
committerPablo Neira Ayuso <pablo@netfilter.org>2018-11-26 10:23:42 +0100
commit2a31e4bd9ad255ee40809b5c798c4b1c2b09703b (patch)
tree0f68039155916d0e041f4a2f8ebc4afcdcbc7baa /include
parentb4e955e9f372035361fbc6f07b21fe2cc6a5be4a (diff)
downloadlinux-stable-2a31e4bd9ad255ee40809b5c798c4b1c2b09703b.tar.gz
linux-stable-2a31e4bd9ad255ee40809b5c798c4b1c2b09703b.tar.bz2
linux-stable-2a31e4bd9ad255ee40809b5c798c4b1c2b09703b.zip
ipvs: call ip_vs_dst_notifier earlier than ipv6_dev_notf
ip_vs_dst_event is supposed to clean up all dst used in ipvs' destinations when a net dev is going down. But it works only when the dst's dev is the same as the dev from the event. Now with the same priority but late registration, ip_vs_dst_notifier is always called later than ipv6_dev_notf where the dst's dev is set to lo for NETDEV_DOWN event. As the dst's dev lo is not the same as the dev from the event in ip_vs_dst_event, ip_vs_dst_notifier doesn't actually work. Also as these dst have to wait for dest_trash_timer to clean them up. It would cause some non-permanent kernel warnings: unregister_netdevice: waiting for br0 to become free. Usage count = 3 To fix it, call ip_vs_dst_notifier earlier than ipv6_dev_notf by increasing its priority to ADDRCONF_NOTIFY_PRIORITY + 5. Note that for ipv4 route fib_netdev_notifier doesn't set dst's dev to lo in NETDEV_DOWN event, so this fix is only needed when IP_VS_IPV6 is defined. Fixes: 7a4f0761fce3 ("IPVS: init and cleanup restructuring") Reported-by: Li Shuang <shuali@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Julian Anastasov <ja@ssi.bg> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions