diff options
| author | Eric Dumazet <edumazet@google.com> | 2018-04-07 13:42:38 -0700 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2018-10-21 08:45:17 +0100 |
| commit | 3c000397b7dd4cc4f5d2f0e4cc7d0495fda5b55c (patch) | |
| tree | 6e140c5a3eb8b83522be51eefe6e112b0dc05bbd /include | |
| parent | 8fe0e06e4829b75c83878431d97af7956af0a2d0 (diff) | |
| download | linux-stable-3c000397b7dd4cc4f5d2f0e4cc7d0495fda5b55c.tar.gz linux-stable-3c000397b7dd4cc4f5d2f0e4cc7d0495fda5b55c.tar.bz2 linux-stable-3c000397b7dd4cc4f5d2f0e4cc7d0495fda5b55c.zip | |
net: fix rtnh_ok()
commit b1993a2de12c9e75c35729e2ffbc3a92d50c0d31 upstream.
syzbot reported :
BUG: KMSAN: uninit-value in rtnh_ok include/net/nexthop.h:11 [inline]
BUG: KMSAN: uninit-value in fib_count_nexthops net/ipv4/fib_semantics.c:469 [inline]
BUG: KMSAN: uninit-value in fib_create_info+0x554/0x8d20 net/ipv4/fib_semantics.c:1091
@remaining is an integer, coming from user space.
If it is negative we want rtnh_ok() to return false.
Fixes: 4e902c57417c ("[IPv4]: FIB configuration using struct fib_config")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/nexthop.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/nexthop.h b/include/net/nexthop.h index 3334dbfa5aa4..7fc78663ec9d 100644 --- a/include/net/nexthop.h +++ b/include/net/nexthop.h @@ -6,7 +6,7 @@ static inline int rtnh_ok(const struct rtnexthop *rtnh, int remaining) { - return remaining >= sizeof(*rtnh) && + return remaining >= (int)sizeof(*rtnh) && rtnh->rtnh_len >= sizeof(*rtnh) && rtnh->rtnh_len <= remaining; } |