diff options
author | Shakeel Butt <shakeelb@google.com> | 2024-01-18 18:42:35 +0000 |
---|---|---|
committer | Andrew Morton <akpm@linux-foundation.org> | 2024-02-22 10:24:38 -0800 |
commit | d9b3ce8769e371554a669f262bbc61c02a40efcc (patch) | |
tree | 770671381b1f9668afbbd80d28f895b86dcbd494 /include | |
parent | 085ff35e76368455c629b194bf3cb62dd82eadf6 (diff) | |
download | linux-stable-d9b3ce8769e371554a669f262bbc61c02a40efcc.tar.gz linux-stable-d9b3ce8769e371554a669f262bbc61c02a40efcc.tar.bz2 linux-stable-d9b3ce8769e371554a669f262bbc61c02a40efcc.zip |
mm: writeback: ratelimit stat flush from mem_cgroup_wb_stats
One of our workloads (Postgres 14) has regressed when migrated from 5.10
to 6.1 upstream kernel. The regression can be reproduced by sysbench's
oltp_write_only benchmark. It seems like the always on rstat flush in
mem_cgroup_wb_stats() is causing the regression. So, rate limit that
specific rstat flush. One potential consequence would be the dirty
throttling might be decided on stale memcg stats. However from our
benchmarks and production traffic we have not observed any change in the
dirty throttling behavior of the application.
Link: https://lkml.kernel.org/r/20240118184235.618164-1-shakeelb@google.com
Fixes: 2d146aa3aa84 ("mm: memcontrol: switch to rstat")
Signed-off-by: Shakeel Butt <shakeelb@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions