diff options
author | Heiner Kallweit <hkallweit1@gmail.com> | 2019-08-12 21:20:02 +0200 |
---|---|---|
committer | Sasha Levin <sashal@kernel.org> | 2019-08-25 10:10:38 -0400 |
commit | 9a31192e1ca12e5e7c80c3600ede8c660728c8f4 (patch) | |
tree | 6ff57453fd608dc8d476a6d68f4d355949cf754a /init/do_mounts_rd.c | |
parent | bc110443a73f275de83d691bccbba9ecd25ca9be (diff) | |
download | linux-stable-9a31192e1ca12e5e7c80c3600ede8c660728c8f4.tar.gz linux-stable-9a31192e1ca12e5e7c80c3600ede8c660728c8f4.tar.bz2 linux-stable-9a31192e1ca12e5e7c80c3600ede8c660728c8f4.zip |
net: phy: consider AN_RESTART status when reading link status
[ Upstream commit c36757eb9dee13681227ad3676d37f14b3a2b2af ]
After configuring and restarting aneg we immediately try to read the
link status. On some systems the PHY may not yet have cleared the
"aneg complete" and "link up" bits, resulting in a false link-up
signal. See [0] for a report.
Clause 22 and 45 both require the PHY to keep the AN_RESTART
bit set until the PHY actually starts auto-negotiation.
Let's consider this in the generic functions for reading link status.
The commit marked as fixed is the first one where the patch applies
cleanly.
[0] https://marc.info/?t=156518400300003&r=1&w=2
Fixes: c1164bb1a631 ("net: phy: check PMAPMD link status only in genphy_c45_read_link")
Tested-by: Yonglong Liu <liuyonglong@huawei.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'init/do_mounts_rd.c')
0 files changed, 0 insertions, 0 deletions