summaryrefslogtreecommitdiffstats
path: root/io_uring
diff options
context:
space:
mode:
authorQi Zheng <zhengqi.arch@bytedance.com>2023-06-09 08:15:14 +0000
committerAndrew Morton <akpm@linux-foundation.org>2023-06-19 13:19:33 -0700
commitc534f7cca6b9b1c0dc97d6e9c5587858d4330cd9 (patch)
tree6dbf4afd21230a1defebb6202f6cc6581cfa9bc4 /io_uring
parent07252b0f97150b03050f74f42250f275566d70b9 (diff)
downloadlinux-stable-c534f7cca6b9b1c0dc97d6e9c5587858d4330cd9.tar.gz
linux-stable-c534f7cca6b9b1c0dc97d6e9c5587858d4330cd9.tar.bz2
linux-stable-c534f7cca6b9b1c0dc97d6e9c5587858d4330cd9.zip
Revert "mm: vmscan: hold write lock to reparent shrinker nr_deferred"
This reverts commit b3cabea3c9153fd42fe5cb851ac58b51ea2b32b8. Kernel test robot reports -88.8% regression in stress-ng.ramfs.ops_per_sec test case [1], which is caused by commit f95bdb700bc6 ("mm: vmscan: make global slab shrink lockless"). The root cause is that SRCU has to be careful to not frequently check for SRCU read-side critical section exits. Therefore, even if no one is currently in the SRCU read-side critical section, synchronize_srcu() cannot return quickly. That's why unregister_shrinker() has become slower. We will try to use the refcount+RCU method [2] proposed by Dave Chinner to continue to re-implement the lockless slab shrink. Because there will be other readers after reverting the shrinker_srcu related changes, so it is better to restore to hold read lock to reparent shrinker nr_deferred. [1]. https://lore.kernel.org/lkml/202305230837.db2c233f-yujie.liu@intel.com/ [2]. https://lore.kernel.org/lkml/ZIJhou1d55d4H1s0@dread.disaster.area/ Link: https://lkml.kernel.org/r/20230609081518.3039120-4-qi.zheng@linux.dev Reported-by: kernel test robot <yujie.liu@intel.com> Closes: https://lore.kernel.org/oe-lkp/202305230837.db2c233f-yujie.liu@intel.com Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com> Cc: Dave Chinner <david@fromorbit.com> Cc: Kirill Tkhai <tkhai@ya.ru> Cc: Muchun Song <muchun.song@linux.dev> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'io_uring')
0 files changed, 0 insertions, 0 deletions