summaryrefslogtreecommitdiffstats
path: root/kernel/events
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2014-05-15 20:23:48 +0200
committerThomas Gleixner <tglx@linutronix.de>2014-05-19 21:44:55 +0900
commit0819b2e30ccb93edf04876237b6205eef84ec8d2 (patch)
tree24d327b78578595da4c822b62a581e557a6d3ee0 /kernel/events
parenta45e903842226071d231924a5bff09d7535109dc (diff)
downloadlinux-stable-0819b2e30ccb93edf04876237b6205eef84ec8d2.tar.gz
linux-stable-0819b2e30ccb93edf04876237b6205eef84ec8d2.tar.bz2
linux-stable-0819b2e30ccb93edf04876237b6205eef84ec8d2.zip
perf: Limit perf_event_attr::sample_period to 63 bits
Vince reported that using a large sample_period (one with bit 63 set) results in wreckage since while the sample_period is fundamentally unsigned (negative periods don't make sense) the way we implement things very much rely on signed logic. So limit sample_period to 63 bits to avoid tripping over this. Reported-by: Vince Weaver <vincent.weaver@maine.edu> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/n/tip-p25fhunibl4y3qi0zuqmyf4b@git.kernel.org Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/events')
-rw-r--r--kernel/events/core.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 71232844f235..1d1ec6453a08 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7029,6 +7029,9 @@ SYSCALL_DEFINE5(perf_event_open,
if (attr.freq) {
if (attr.sample_freq > sysctl_perf_event_sample_rate)
return -EINVAL;
+ } else {
+ if (attr.sample_period & (1ULL << 63))
+ return -EINVAL;
}
/*