diff options
author | Kai Vehmanen <kai.vehmanen@linux.intel.com> | 2019-12-31 16:00:07 +0200 |
---|---|---|
committer | Matt Roper <matthew.d.roper@intel.com> | 2020-01-06 08:45:35 -0800 |
commit | 1ee48a61aa57dbdbc3cd2808d8b28df40d938e44 (patch) | |
tree | e3041d55124270252652f79ce57ed5ce300a59c4 /kernel/softirq.c | |
parent | f75fc37b5e70b75f21550410f88e2379648120e2 (diff) | |
download | linux-stable-1ee48a61aa57dbdbc3cd2808d8b28df40d938e44.tar.gz linux-stable-1ee48a61aa57dbdbc3cd2808d8b28df40d938e44.tar.bz2 linux-stable-1ee48a61aa57dbdbc3cd2808d8b28df40d938e44.zip |
drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only
Revert changes done in commit f6ec9483091f ("drm/i915: extend audio
CDCLK>=2*BCLK constraint to more platforms"). Audio drivers
communicate with i915 over HDA bus multiple times during system
boot-up and each of these transactions result in matching
get_power/put_power calls to i915, and depending on the platform,
a modeset change causing visible flicker.
GLK is the only platform with minimum CDCLK significantly lower
than BCLK, and thus for GLK setting a higher CDCLK is mandatory.
For other platforms, minimum CDCLK is close but below 2*BCLK
(e.g. on ICL, CDCLK=176.4kHz with BCLK=96kHz). Spec-wise the constraint
should be set, but in practise no communication errors have been
reported and the downside if set is the flicker observed at boot-time.
Revert to old behaviour until better mechanism to manage
probe-time clocks is available.
The full CDCLK>=2*BCLK constraint is still enforced at pipe
enable time in intel_crtc_compute_min_cdclk().
Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/913
Fixes: f6ec9483091f ("drm/i915: extend audio CDCLK>=2*BCLK constraint to more platforms")
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191231140007.31728-1-kai.vehmanen@linux.intel.com
Diffstat (limited to 'kernel/softirq.c')
0 files changed, 0 insertions, 0 deletions