summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorStefan-gabriel Mirea <stefan-gabriel.mirea@nxp.com>2019-09-18 18:45:49 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-10-04 15:02:28 +0200
commit9050079719021776e48437827eb9d5986b6e45d4 (patch)
tree87393e2b295a150a261933f3039e37fa05330636 /kernel
parent392fb8df528b97a06e19312772afd38aec542b96 (diff)
downloadlinux-stable-9050079719021776e48437827eb9d5986b6e45d4.tar.gz
linux-stable-9050079719021776e48437827eb9d5986b6e45d4.tar.bz2
linux-stable-9050079719021776e48437827eb9d5986b6e45d4.zip
tty: serial: linflexuart: Fix magic SysRq handling
Following an incorrect indentation reported to me by Dan Carpenter, I noticed that the SysRq lines were inherited from the lpuart driver[1] (note how the 'continue' is aligned to 'sport->port.sysrq = 0') and we have never actually tested the SysRq support. 'sport->sysrq = 0' is not necessary neither before nor after 'continue', because sysrq will already be 0 after uart_handle_sysrq_char() will finish. Also, since the LINFlexD driver never called uart_handle_break(), sysrq would have never been set to a nonzero value, so uart_handle_sysrq_char() was not going to do anything. Break conditions are detected based on a null data byte along with a framing error (stop bit sampled to 0). [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/fsl_lpuart.c?h=b3e3bf2ef2c74f5ce5c19510edbbb9bfc1d249c2#n659 Fixes: 09864c1cdf5c ("tty: serial: Add linflexuart driver for S32V234") Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@nxp.com> Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/20190918184439.7465-1-stefan-gabriel.mirea@nxp.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions