summaryrefslogtreecommitdiffstats
path: root/lib/error-inject.c
diff options
context:
space:
mode:
authorKunwu Chan <chentao@kylinos.cn>2024-01-15 16:28:25 +0800
committerTony Nguyen <anthony.l.nguyen@intel.com>2024-02-14 09:43:09 -0800
commitc56d055893cbe97848611855d1c97d0ab171eccc (patch)
tree0e91caaf3512c822e6354de41a416a6fbe5e5533 /lib/error-inject.c
parent9b23fceb4158a3636ce4a2bda28ab03dcfa6a26f (diff)
downloadlinux-stable-c56d055893cbe97848611855d1c97d0ab171eccc.tar.gz
linux-stable-c56d055893cbe97848611855d1c97d0ab171eccc.tar.bz2
linux-stable-c56d055893cbe97848611855d1c97d0ab171eccc.zip
igb: Fix string truncation warnings in igb_set_fw_version
Commit 1978d3ead82c ("intel: fix string truncation warnings") fixes '-Wformat-truncation=' warnings in igb_main.c by using kasprintf. drivers/net/ethernet/intel/igb/igb_main.c:3092:53: warning:‘%d’ directive output may be truncated writing between 1 and 5 bytes into a region of size between 1 and 13 [-Wformat-truncation=] 3092 | "%d.%d, 0x%08x, %d.%d.%d", | ^~ drivers/net/ethernet/intel/igb/igb_main.c:3092:34: note:directive argument in the range [0, 65535] 3092 | "%d.%d, 0x%08x, %d.%d.%d", | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/intel/igb/igb_main.c:3092:34: note:directive argument in the range [0, 65535] drivers/net/ethernet/intel/igb/igb_main.c:3090:25: note:‘snprintf’ output between 23 and 43 bytes into a destination of size 32 kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Fix this warning by using a larger space for adapter->fw_version, and then fall back and continue to use snprintf. Fixes: 1978d3ead82c ("intel: fix string truncation warnings") Signed-off-by: Kunwu Chan <chentao@kylinos.cn> Cc: Kunwu Chan <kunwu.chan@hotmail.com> Suggested-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'lib/error-inject.c')
0 files changed, 0 insertions, 0 deletions