summaryrefslogtreecommitdiffstats
path: root/lib/kunit
diff options
context:
space:
mode:
authorJinjie Ruan <ruanjinjie@huawei.com>2023-09-27 17:03:48 +0800
committerShuah Khan <skhan@linuxfoundation.org>2023-09-28 08:50:57 -0600
commite44679515a7b803cf0143dc9de3d2ecbe907f939 (patch)
tree809b79599caaf2ccb9900d57caeea9d79d105ee6 /lib/kunit
parenta6074cf0126b0bee51ab77a15930dc24a4d5db90 (diff)
downloadlinux-stable-e44679515a7b803cf0143dc9de3d2ecbe907f939.tar.gz
linux-stable-e44679515a7b803cf0143dc9de3d2ecbe907f939.tar.bz2
linux-stable-e44679515a7b803cf0143dc9de3d2ecbe907f939.zip
kunit: Fix the wrong kfree of copy for kunit_filter_suites()
If the outer layer for loop is iterated more than once and it fails not in the first iteration, the copy pointer has been moved. So it should free the original copy's backup copy_start. Fixes: abbf73816b6f ("kunit: fix possible memory leak in kunit_filter_suites()") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Reviewed-by: Rae Moar <rmoar@google.com> Reviewed-by: David Gow <davidgow@google.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'lib/kunit')
-rw-r--r--lib/kunit/executor.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
index a037a46fae5e..9358ed2df839 100644
--- a/lib/kunit/executor.c
+++ b/lib/kunit/executor.c
@@ -243,7 +243,7 @@ free_parsed_glob:
free_copy:
if (*err)
- kfree(copy);
+ kfree(copy_start);
return filtered;
}