diff options
author | David Howells <dhowells@redhat.com> | 2015-09-25 16:30:08 +0100 |
---|---|---|
committer | Luis Henriques <luis.henriques@canonical.com> | 2015-10-28 10:33:22 +0000 |
commit | 35694b04cebccf2e845ecf93a606fae1982c6390 (patch) | |
tree | 0356e7b993c033697a82c9979af6b6e17a293f9f /lib/llist.c | |
parent | fa89ae5548ed282f0ceb4660b3b93e4e2ee875f3 (diff) | |
download | linux-stable-35694b04cebccf2e845ecf93a606fae1982c6390.tar.gz linux-stable-35694b04cebccf2e845ecf93a606fae1982c6390.tar.bz2 linux-stable-35694b04cebccf2e845ecf93a606fae1982c6390.zip |
KEYS: Fix race between key destruction and finding a keyring by name
commit 94c4554ba07adbdde396748ee7ae01e86cf2d8d7 upstream.
There appears to be a race between:
(1) key_gc_unused_keys() which frees key->security and then calls
keyring_destroy() to unlink the name from the name list
(2) find_keyring_by_name() which calls key_permission(), thus accessing
key->security, on a key before checking to see whether the key usage is 0
(ie. the key is dead and might be cleaned up).
Fix this by calling ->destroy() before cleaning up the core key data -
including key->security.
Reported-by: Petr Matousek <pmatouse@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'lib/llist.c')
0 files changed, 0 insertions, 0 deletions