summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>2023-12-29 15:39:11 +0900
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>2023-12-29 15:30:05 +0200
commitb28ff7a7c3245d7f62acc20f15b4361292fe4117 (patch)
tree2f47fa629628a8d2eda0c063e3e60e8f26f2f85d /lib
parenta55bdad5dfd1efd4ed9ffe518897a21ca8e4e193 (diff)
downloadlinux-stable-b28ff7a7c3245d7f62acc20f15b4361292fe4117.tar.gz
linux-stable-b28ff7a7c3245d7f62acc20f15b4361292fe4117.tar.bz2
linux-stable-b28ff7a7c3245d7f62acc20f15b4361292fe4117.zip
platform/x86: p2sb: Allow p2sb_bar() calls during PCI device probe
p2sb_bar() unhides P2SB device to get resources from the device. It guards the operation by locking pci_rescan_remove_lock so that parallel rescans do not find the P2SB device. However, this lock causes deadlock when PCI bus rescan is triggered by /sys/bus/pci/rescan. The rescan locks pci_rescan_remove_lock and probes PCI devices. When PCI devices call p2sb_bar() during probe, it locks pci_rescan_remove_lock again. Hence the deadlock. To avoid the deadlock, do not lock pci_rescan_remove_lock in p2sb_bar(). Instead, do the lock at fs_initcall. Introduce p2sb_cache_resources() for fs_initcall which gets and caches the P2SB resources. At p2sb_bar(), refer the cache and return to the caller. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Fixes: 9745fb07474f ("platform/x86/intel: Add Primary to Sideband (P2SB) bridge support") Cc: stable@vger.kernel.org Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/linux-pci/6xb24fjmptxxn5js2fjrrddjae6twex5bjaftwqsuawuqqqydx@7cl3uik5ef6j/ Link: https://lore.kernel.org/r/20231229063912.2517922-2-shinichiro.kawasaki@wdc.com Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions