diff options
author | Andrey Smirnov <andrew.smirnov@gmail.com> | 2019-08-12 13:08:58 -0700 |
---|---|---|
committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2019-09-17 08:59:07 +0200 |
commit | d2ddc4505ed268a57bfc07817bc0494aca6d8818 (patch) | |
tree | f9dc706dc282ca5d7de18bd003c1dec36d7b1269 /lib | |
parent | de88053807d848a504a65fbe7ea03c9aedc16b90 (diff) | |
download | linux-stable-d2ddc4505ed268a57bfc07817bc0494aca6d8818.tar.gz linux-stable-d2ddc4505ed268a57bfc07817bc0494aca6d8818.tar.bz2 linux-stable-d2ddc4505ed268a57bfc07817bc0494aca6d8818.zip |
watchdog: ziirave_wdt: Don't try to program readonly flash
Bootloader code will ignore any attempts to write data to any flash
area outside of [ZIIRAVE_FIRM_FLASH_MEMORY_START;
ZIIRAVE_FIRM_FLASH_MEMORY_END]. Firmware update code already have an
appropriate check to skip those areas when validating updated
firmware. Firmware programming code, OTOH, does not and will
needlessly send no-op I2C traffic. Add an appropriate check to
__ziirave_firm_write_pkt() so as to save all of that wasted effort.
While at it, normalize all of the address handling code to use full
32-bit address in units of bytes and convert it to an appropriate
value only in places where that is necessary.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Rick Ramstetter <rick@anteaterllc.com>
Cc: linux-watchdog@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20190812200906.31344-15-andrew.smirnov@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions