summaryrefslogtreecommitdiffstats
path: root/net/batman-adv/bridge_loop_avoidance.c
diff options
context:
space:
mode:
authorSven Eckelmann <sven@narfation.org>2016-07-15 17:39:25 +0200
committerSimon Wunderlich <sw@simonwunderlich.de>2016-08-09 07:54:48 +0200
commit4e8389e17a97c6bdd927d33f6e5d505c08a85a4f (patch)
tree6d9bc510ea2ccf4503ce053a3e4266b9ce5acd67 /net/batman-adv/bridge_loop_avoidance.c
parent7282ac396ea617a0a4f8f89389f84690f8431d7d (diff)
downloadlinux-stable-4e8389e17a97c6bdd927d33f6e5d505c08a85a4f.tar.gz
linux-stable-4e8389e17a97c6bdd927d33f6e5d505c08a85a4f.tar.bz2
linux-stable-4e8389e17a97c6bdd927d33f6e5d505c08a85a4f.zip
batman-adv: Place kref_get for bla_backbone_gw near use
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems caused by incorrect reference counting. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv/bridge_loop_avoidance.c')
-rw-r--r--net/batman-adv/bridge_loop_avoidance.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index b0517a0bc8e7..1db3c12c0be0 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -526,11 +526,9 @@ batadv_bla_get_backbone_gw(struct batadv_priv *bat_priv, u8 *orig,
atomic_set(&entry->wait_periods, 0);
ether_addr_copy(entry->orig, orig);
INIT_WORK(&entry->report_work, batadv_bla_loopdetect_report);
-
- /* one for the hash, one for returning */
kref_init(&entry->refcount);
- kref_get(&entry->refcount);
+ kref_get(&entry->refcount);
hash_added = batadv_hash_add(bat_priv->bla.backbone_hash,
batadv_compare_backbone_gw,
batadv_choose_backbone_gw, entry,