summaryrefslogtreecommitdiffstats
path: root/net/devlink
diff options
context:
space:
mode:
authorParav Pandit <parav@nvidia.com>2024-01-29 21:10:59 +0200
committerJakub Kicinski <kuba@kernel.org>2024-01-30 18:32:41 -0800
commit1a89e24f8bfd3e3562d69709c9d9cd185ded869b (patch)
treecd8c94fad18d5a1ea745cf54b68ce9c0be5c684d /net/devlink
parentf5c3eb4b7251baba5cd72c9e93920e710ac8194a (diff)
downloadlinux-stable-1a89e24f8bfd3e3562d69709c9d9cd185ded869b.tar.gz
linux-stable-1a89e24f8bfd3e3562d69709c9d9cd185ded869b.tar.bz2
linux-stable-1a89e24f8bfd3e3562d69709c9d9cd185ded869b.zip
devlink: Fix referring to hw_addr attribute during state validation
When port function state change is requested, and when the driver does not support it, it refers to the hw address attribute instead of state attribute. Seems like a copy paste error. Fix it by referring to the port function state attribute. Fixes: c0bea69d1ca7 ("devlink: Validate port function request") Signed-off-by: Parav Pandit <parav@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Link: https://lore.kernel.org/r/20240129191059.129030-1-parav@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/devlink')
-rw-r--r--net/devlink/port.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/devlink/port.c b/net/devlink/port.c
index 62e54e152ecf..78592912f657 100644
--- a/net/devlink/port.c
+++ b/net/devlink/port.c
@@ -674,7 +674,7 @@ static int devlink_port_function_validate(struct devlink_port *devlink_port,
return -EOPNOTSUPP;
}
if (tb[DEVLINK_PORT_FN_ATTR_STATE] && !ops->port_fn_state_set) {
- NL_SET_ERR_MSG_ATTR(extack, tb[DEVLINK_PORT_FUNCTION_ATTR_HW_ADDR],
+ NL_SET_ERR_MSG_ATTR(extack, tb[DEVLINK_PORT_FN_ATTR_STATE],
"Function does not support state setting");
return -EOPNOTSUPP;
}