diff options
author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-03-27 17:15:39 +0100 |
---|---|---|
committer | Chuck Lever <chuck.lever@oracle.com> | 2020-03-27 12:22:57 -0400 |
commit | b25b60d7bfb02a74bc3c2d998e09aab159df8059 (patch) | |
tree | ce9bc621da0ec4d6e15d0760fe121d6ed7341383 /net/dns_resolver | |
parent | 9a81ef42b238b28829a46ecf13c7aacb79b9b3ac (diff) | |
download | linux-stable-b25b60d7bfb02a74bc3c2d998e09aab159df8059.tar.gz linux-stable-b25b60d7bfb02a74bc3c2d998e09aab159df8059.tar.bz2 linux-stable-b25b60d7bfb02a74bc3c2d998e09aab159df8059.zip |
SUNRPC: Fix a potential buffer overflow in 'svc_print_xprts()'
'maxlen' is the total size of the destination buffer. There is only one
caller and this value is 256.
When we compute the size already used and what we would like to add in
the buffer, the trailling NULL character is not taken into account.
However, this trailling character will be added by the 'strcat' once we
have checked that we have enough place.
So, there is a off-by-one issue and 1 byte of the stack could be
erroneously overwridden.
Take into account the trailling NULL, when checking if there is enough
place in the destination buffer.
While at it, also replace a 'sprintf' by a safer 'snprintf', check for
output truncation and avoid a superfluous 'strlen'.
Fixes: dc9a16e49dbba ("svc: Add /proc/sys/sunrpc/transport files")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
[ cel: very minor fix to documenting comment
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'net/dns_resolver')
0 files changed, 0 insertions, 0 deletions