diff options
author | Florian Fainelli <f.fainelli@gmail.com> | 2017-04-08 08:55:23 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-04-08 13:49:36 -0700 |
commit | a86d8becc3f04a5e350b5a17530e6a01495c00a5 (patch) | |
tree | 93e0c28cdfcac7bb616f9b767c4a782a2e620bce /net/dsa/tag_mtk.c | |
parent | 16c5dcb13a371feae0e680e6518775b5335b37d8 (diff) | |
download | linux-stable-a86d8becc3f04a5e350b5a17530e6a01495c00a5.tar.gz linux-stable-a86d8becc3f04a5e350b5a17530e6a01495c00a5.tar.bz2 linux-stable-a86d8becc3f04a5e350b5a17530e6a01495c00a5.zip |
net: dsa: Factor bottom tag receive functions
All DSA tag receive functions do strictly the same thing after they have located
the originating source port from their tag specific protocol:
- push ETH_HLEN bytes
- set pkt_type to PACKET_HOST
- call eth_type_trans()
- bump up counters
- call netif_receive_skb()
Factor all of that into dsa_switch_rcv(). This also makes us return a pointer to
a sk_buff, which makes us symetric with the xmit function.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/tag_mtk.c')
-rw-r--r-- | net/dsa/tag_mtk.c | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/net/dsa/tag_mtk.c b/net/dsa/tag_mtk.c index d0a477084870..837cdddb53f0 100644 --- a/net/dsa/tag_mtk.c +++ b/net/dsa/tag_mtk.c @@ -47,8 +47,9 @@ out_free: return NULL; } -static int mtk_tag_rcv(struct sk_buff *skb, struct net_device *dev, - struct packet_type *pt, struct net_device *orig_dev) +static struct sk_buff *mtk_tag_rcv(struct sk_buff *skb, struct net_device *dev, + struct packet_type *pt, + struct net_device *orig_dev) { struct dsa_switch_tree *dst = dev->dsa_ptr; struct dsa_switch *ds; @@ -85,23 +86,12 @@ static int mtk_tag_rcv(struct sk_buff *skb, struct net_device *dev, if (!ds->ports[port].netdev) goto out_drop; - /* Update skb & forward the frame accordingly */ - skb_push(skb, ETH_HLEN); - - skb->pkt_type = PACKET_HOST; skb->dev = ds->ports[port].netdev; - skb->protocol = eth_type_trans(skb, skb->dev); - - skb->dev->stats.rx_packets++; - skb->dev->stats.rx_bytes += skb->len; - - netif_receive_skb(skb); - return 0; + return skb; out_drop: - kfree_skb(skb); - return 0; + return NULL; } const struct dsa_device_ops mtk_netdev_ops = { |