diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2021-08-10 16:13:53 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-08-11 14:44:58 +0100 |
| commit | f1dacd7aea34333620bd5177a8808a3296a63184 (patch) | |
| tree | 273cc438c8f33fc92fc42757b8b10eff1c82bd74 /net/dsa/tag_rtl4_a.c | |
| parent | 1a8e628c8a3e38af1392197adf086de7ce51d24f (diff) | |
| download | linux-stable-f1dacd7aea34333620bd5177a8808a3296a63184.tar.gz linux-stable-f1dacd7aea34333620bd5177a8808a3296a63184.tar.bz2 linux-stable-f1dacd7aea34333620bd5177a8808a3296a63184.zip | |
net: dsa: create a helper that strips EtherType DSA headers on RX
All header taggers open-code a memmove that is fairly not all that
obvious, and we can hide the details behind a helper function, since the
only thing specific to the driver is the length of the header tag.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/tag_rtl4_a.c')
| -rw-r--r-- | net/dsa/tag_rtl4_a.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/dsa/tag_rtl4_a.c b/net/dsa/tag_rtl4_a.c index aaddca3c0245..ff8707ff0c5b 100644 --- a/net/dsa/tag_rtl4_a.c +++ b/net/dsa/tag_rtl4_a.c @@ -108,10 +108,7 @@ static struct sk_buff *rtl4a_tag_rcv(struct sk_buff *skb, /* Remove RTL4 tag and recalculate checksum */ skb_pull_rcsum(skb, RTL4_A_HDR_LEN); - /* Move ethernet DA and SA in front of the data */ - memmove(skb->data - ETH_HLEN, - skb->data - ETH_HLEN - RTL4_A_HDR_LEN, - 2 * ETH_ALEN); + dsa_strip_etype_header(skb, RTL4_A_HDR_LEN); dsa_default_offload_fwd_mark(skb); |