diff options
| author | Eric Dumazet <edumazet@google.com> | 2023-09-21 20:28:18 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-11-28 17:19:38 +0000 |
| commit | 87324a50b4e833289bbe22339eccbc42e4d0578a (patch) | |
| tree | 503b780cbc113a96d3d7c8c9ebd157fcf18cba6a /net/ipv4 | |
| parent | 224f68c507b1eb6af1421af4a23680df6849c710 (diff) | |
| download | linux-stable-87324a50b4e833289bbe22339eccbc42e4d0578a.tar.gz linux-stable-87324a50b4e833289bbe22339eccbc42e4d0578a.tar.bz2 linux-stable-87324a50b4e833289bbe22339eccbc42e4d0578a.zip | |
net: annotate data-races around sk->sk_dst_pending_confirm
[ Upstream commit eb44ad4e635132754bfbcb18103f1dcb7058aedd ]
This field can be read or written without socket lock being held.
Add annotations to avoid load-store tearing.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index f0723460753c..9ccfdc825004 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -1331,7 +1331,7 @@ static int __tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, skb->destructor = skb_is_tcp_pure_ack(skb) ? __sock_wfree : tcp_wfree; refcount_add(skb->truesize, &sk->sk_wmem_alloc); - skb_set_dst_pending_confirm(skb, sk->sk_dst_pending_confirm); + skb_set_dst_pending_confirm(skb, READ_ONCE(sk->sk_dst_pending_confirm)); /* Build TCP header and checksum it. */ th = (struct tcphdr *)skb->data; |