diff options
author | Eric Dumazet <edumazet@google.com> | 2022-03-22 17:41:47 -0700 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-03-28 09:58:42 +0200 |
commit | e9072996108387ab19b497f5b557c93f98d96b0b (patch) | |
tree | b5eda13286198738fec01b7ae351cddf5438b337 /net/llc | |
parent | 5b2ca3b8213a49940cb88d29034cbdaa3fbaccb7 (diff) | |
download | linux-stable-e9072996108387ab19b497f5b557c93f98d96b0b.tar.gz linux-stable-e9072996108387ab19b497f5b557c93f98d96b0b.tar.bz2 linux-stable-e9072996108387ab19b497f5b557c93f98d96b0b.zip |
llc: fix netdevice reference leaks in llc_ui_bind()
commit 764f4eb6846f5475f1244767d24d25dd86528a4a upstream.
Whenever llc_ui_bind() and/or llc_ui_autobind()
took a reference on a netdevice but subsequently fail,
they must properly release their reference
or risk the infamous message from unregister_netdevice()
at device dismantle.
unregister_netdevice: waiting for eth0 to become free. Usage count = 3
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: 赵子轩 <beraphin@gmail.com>
Reported-by: Stoyan Manolov <smanolov@suse.de>
Link: https://lore.kernel.org/r/20220323004147.1990845-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/llc')
-rw-r--r-- | net/llc/af_llc.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index 3086f4a6ae68..fb88971a40ae 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -310,6 +310,10 @@ static int llc_ui_autobind(struct socket *sock, struct sockaddr_llc *addr) sock_reset_flag(sk, SOCK_ZAPPED); rc = 0; out: + if (rc) { + dev_put(llc->dev); + llc->dev = NULL; + } return rc; } @@ -407,6 +411,10 @@ static int llc_ui_bind(struct socket *sock, struct sockaddr *uaddr, int addrlen) out_put: llc_sap_put(sap); out: + if (rc) { + dev_put(llc->dev); + llc->dev = NULL; + } release_sock(sk); return rc; } |