summaryrefslogtreecommitdiffstats
path: root/net/netlabel
diff options
context:
space:
mode:
authorAlex Dewar <alex.dewar90@gmail.com>2020-08-28 14:55:23 +0100
committerDavid S. Miller <davem@davemloft.net>2020-08-28 09:08:51 -0700
commit0f091e43310f5c292b7094f9f115e651358e8053 (patch)
tree3a162e1b913a7d9e397cdbf67996d1e068b9d752 /net/netlabel
parentf3fb15b93aa992fdda5cf5351aaefc4a58342a2c (diff)
downloadlinux-stable-0f091e43310f5c292b7094f9f115e651358e8053.tar.gz
linux-stable-0f091e43310f5c292b7094f9f115e651358e8053.tar.bz2
linux-stable-0f091e43310f5c292b7094f9f115e651358e8053.zip
netlabel: remove unused param from audit_log_format()
Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") added a check to return an error if ret_val != 0, before ret_val is later used in a log message. Now it will unconditionally print "... res=1". So just drop the check. Addresses-Coverity: ("Dead code") Fixes: d3b990b7f327 ("netlabel: fix problems with mapping removal") Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> Acked-by: Paul Moore <paul@paul-moore.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlabel')
-rw-r--r--net/netlabel/netlabel_domainhash.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/net/netlabel/netlabel_domainhash.c b/net/netlabel/netlabel_domainhash.c
index d07de2c0fbc7..38aaeadec13d 100644
--- a/net/netlabel/netlabel_domainhash.c
+++ b/net/netlabel/netlabel_domainhash.c
@@ -600,9 +600,8 @@ int netlbl_domhsh_remove_entry(struct netlbl_dom_map *entry,
audit_buf = netlbl_audit_start_common(AUDIT_MAC_MAP_DEL, audit_info);
if (audit_buf != NULL) {
audit_log_format(audit_buf,
- " nlbl_domain=%s res=%u",
- entry->domain ? entry->domain : "(default)",
- ret_val == 0 ? 1 : 0);
+ " nlbl_domain=%s res=1",
+ entry->domain ? entry->domain : "(default)");
audit_log_end(audit_buf);
}