summaryrefslogtreecommitdiffstats
path: root/net/sctp
diff options
context:
space:
mode:
authorHoratiu Vultur <horatiu.vultur@microchip.com>2020-02-17 09:31:33 +0100
committerDavid S. Miller <davem@davemloft.net>2020-02-17 14:02:29 -0800
commita81541041ceb55bcec9a8bb8ad3482263f0a205a (patch)
tree7fb3aa23693451957941ab154652f12fd610cbae /net/sctp
parent9a6a0dea16177ccaecc116f560232e63bec115f1 (diff)
downloadlinux-stable-a81541041ceb55bcec9a8bb8ad3482263f0a205a.tar.gz
linux-stable-a81541041ceb55bcec9a8bb8ad3482263f0a205a.tar.bz2
linux-stable-a81541041ceb55bcec9a8bb8ad3482263f0a205a.zip
net: mscc: fix in frame extraction
Each extracted frame on Ocelot has an IFH. The frame and IFH are extracted by reading chuncks of 4 bytes from a register. In case the IFH and frames were read corretly it would try to read the next frame. In case there are no more frames in the queue, it checks if there were any previous errors and in that case clear the queue. But this check will always succeed also when there are no errors. Because when extracting the IFH the error is checked against 4(number of bytes read) and then the error is set only if the extraction of the frame failed. So in a happy case where there are no errors the err variable is still 4. So it could be a case where after the check that there are no more frames in the queue, a frame will arrive in the queue but because the error is not reseted, it would try to flush the queue. So the frame will be lost. The fix consist in resetting the error after reading the IFH. Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
0 files changed, 0 insertions, 0 deletions