summaryrefslogtreecommitdiffstats
path: root/net/tipc
diff options
context:
space:
mode:
authorHangyu Hua <hbh25y@gmail.com>2022-06-29 14:34:18 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-07-21 21:24:35 +0200
commit833ecd0eae76eadf81d6d747bb5bc992d1151867 (patch)
tree7c410a8709ee17b07d611a2ed84fcef6e6e6ed63 /net/tipc
parent13d28e0c79cbf69fc6f145767af66905586c1249 (diff)
downloadlinux-stable-833ecd0eae76eadf81d6d747bb5bc992d1151867.tar.gz
linux-stable-833ecd0eae76eadf81d6d747bb5bc992d1151867.tar.bz2
linux-stable-833ecd0eae76eadf81d6d747bb5bc992d1151867.zip
net: tipc: fix possible refcount leak in tipc_sk_create()
[ Upstream commit 00aff3590fc0a73bddd3b743863c14e76fd35c0c ] Free sk in case tipc_sk_insert() fails. Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Reviewed-by: Tung Nguyen <tung.q.nguyen@dektech.com.au> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'net/tipc')
-rw-r--r--net/tipc/socket.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 17f8c523e33b..43509c7e90fc 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -502,6 +502,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock,
sock_init_data(sock, sk);
tipc_set_sk_state(sk, TIPC_OPEN);
if (tipc_sk_insert(tsk)) {
+ sk_free(sk);
pr_warn("Socket create failed; port number exhausted\n");
return -EINVAL;
}