summaryrefslogtreecommitdiffstats
path: root/net/x25/x25_forward.c
diff options
context:
space:
mode:
authorJon Maloy <jmaloy@redhat.com>2022-02-05 14:11:18 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2022-02-10 05:37:44 -0800
commit9aa422ad326634b76309e8ff342c246800621216 (patch)
tree37ef85f7cefa262cbef025fa5ca736a59440259a /net/x25/x25_forward.c
parentf4bc5bbb5fef3cf421ba3485d6d383c27ec473ed (diff)
downloadlinux-stable-9aa422ad326634b76309e8ff342c246800621216.tar.gz
linux-stable-9aa422ad326634b76309e8ff342c246800621216.tar.bz2
linux-stable-9aa422ad326634b76309e8ff342c246800621216.zip
tipc: improve size validations for received domain records
The function tipc_mon_rcv() allows a node to receive and process domain_record structs from peer nodes to track their views of the network topology. This patch verifies that the number of members in a received domain record does not exceed the limit defined by MAX_MON_DOMAIN, something that may otherwise lead to a stack overflow. tipc_mon_rcv() is called from the function tipc_link_proto_rcv(), where we are reading a 32 bit message data length field into a uint16. To avert any risk of bit overflow, we add an extra sanity check for this in that function. We cannot see that happen with the current code, but future designers being unaware of this risk, may introduce it by allowing delivery of very large (> 64k) sk buffers from the bearer layer. This potential problem was identified by Eric Dumazet. This fixes CVE-2022-0435 Reported-by: Samuel Page <samuel.page@appgate.com> Reported-by: Eric Dumazet <edumazet@google.com> Fixes: 35c55c9877f8 ("tipc: add neighbor monitoring framework") Signed-off-by: Jon Maloy <jmaloy@redhat.com> Reviewed-by: Xin Long <lucien.xin@gmail.com> Reviewed-by: Samuel Page <samuel.page@appgate.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/x25/x25_forward.c')
0 files changed, 0 insertions, 0 deletions